What fresh hell is THIS now? - Patrick Lauke
[johnkmcnabb] Can someone with Ember experience please tell me if this code is valid? It looks odd to me - there's a ui-checkbox tag with role="checkbox", and nested inside of that is a native input tag with type="checkbox". Isn't it strange to have a checkbox within a checkbox?
<div class="checkbox-wrapper">
<div id="ember859" class="ember-view ui-set-checkbox">
<ui-checkbox id="ember870" role="checkbox" aria-label="Don't show this again" aria-checked="false" tabindex="0" class="ember-view ui-checkbox ui-display-default">
<input type="checkbox" tabindex="0" aria-hidden="true" id="ember870-input">
<div class="ui-wrapper">
<!---->
</div>
</ui-checkbox>
<label class="ui-partial-label" id="ember870-label" for="ember870-input">
Don't show this again
<!---->
</label>
<!---->
<!---->
<div id="ember879" aria-live="assertive" class="ember-view ui-set-messages">
<!---->
</div>
</div>
</div>
This code seems to be causing problems on some browser + screen reader combinations, but the Ember developer says it works with most browsers and screen readers, so it must be fine.
[johnkmcnabb] I'm sorry I couldn't share more of the code, but it's not easy to get content from my work laptop (it's completely locked down).
But from this code it appears to me that the developer is creating an Ember checkbox and a native checkbox - each with partial functionality - rather than creating one checkbox that has everything we need.